System Test: Module (WAZUH-DB) - Agent never_connected connects - default group #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously worked on branch 2505_agent_groups_default
13 tasks
…ub.com/wazuh/wazuh-qa into tmp-2505-test-agent-groups-default
Tests Results
|
Deblintrake09
approved these changes
Mar 14, 2022
damarisg
requested changes
Mar 15, 2022
tests/system/test_cluster/test_agent_groups/test_agent_groups_default.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_agent_groups_default.py
Outdated
Show resolved
Hide resolved
| @pytest.mark.parametrize("test_infra_managers",[test_infra_managers]) | ||
| @pytest.mark.parametrize("test_infra_agents",[test_infra_agents]) | ||
| @pytest.mark.parametrize("host_manager",[host_manager]) | ||
| @pytest.mark.parametrize("agent_target", test_infra_managers) |
There was a problem hiding this comment.
Why is agent_target not a list and contains test_infra_manager?
There was a problem hiding this comment.
Parametrize requires a list of values, and test_infra_managers is a list of all manager hosts, so it is passed that way, not inside a list.
| @pytest.mark.parametrize("test_infra_agents",[test_infra_agents]) | ||
| @pytest.mark.parametrize("host_manager",[host_manager]) | ||
| @pytest.mark.parametrize("agent_target", test_infra_managers) | ||
| def test_agent_default_group(agent_target, clean_environment, test_infra_managers, test_infra_agents, host_manager): |
There was a problem hiding this comment.
Change the module name and the path with the new module name. Ex: test_agent_added_the_default_group.
Also, when you change it, you should change the path in the documentation.
There was a problem hiding this comment.
Changed name to test_agent_default_group_added.
Did not add to path in documentation since it was removed as requested
tests/system/test_cluster/test_agent_groups/test_agent_groups_default.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_agent_groups_default.py
Outdated
Show resolved
Hide resolved
tests/system/test_cluster/test_agent_groups/test_agent_groups_default.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Dámaris <[email protected]>
…azuh-qa into system_test_wazuh_db
Tests Results
|
damarisg
approved these changes
Mar 15, 2022
15 tasks
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the test suite for
Agent never_connected connectsis added. A total of 2 new test cases covering different modes and combinations of options.Cases:
- The agent on active status and connect to
masternode has the default group- The agent on active status and connect to
workernode has the default groupConfiguration options
In order to run the test, first the environment located in
/test/system/provisioning/enrollment_clustermust be enabled with:sudo ansible-playbook -i inventory.yml playbook.yml --extra-vars='{"wazuh_branch": "dev-10771-agent-groups-files-to-wazuh-db"}'Local Internal Options: No Local Internal Options used
Tests Results
Required
pycodestyle --max-line-length=120 --show-source --show-pep8 file.py.